Clean up Wasm test setup #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify test source sets structure by removing the nonWasmTest intermediate source set. Now that kotlinx-resources 0.13.0 supports Wasm, all platforms can use the resource-loading mechanism directly.
goncalossilva
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates Kotlin from version 2.2.21 to 2.3.0 (required for kotlinx-resources 0.13.0) and upgrades kotlinx-resources from 0.11.0 to 0.13.0 to enable Wasm support. The update allows for consolidation of test infrastructure by removing the platform-specific test source sets (nonWasmTest and wasmJsTest) and unifying resource loading across all platforms.
Key Changes:
- Updated Kotlin version to 2.3.0 in buildSrc dependencies
- Updated kotlinx-resources plugin and library to version 0.13.0
- Unified test resource loading by moving implementation from platform-specific source sets to commonTest
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| buildSrc/build.gradle.kts | Updated Kotlin Gradle plugin from 2.2.21 to 2.3.0 |
| build.gradle.kts | Updated kotlinx-resources plugin from 0.11.0 to 0.13.0 and added resources library dependency to commonTest |
| src/commonTest/kotlin/NormalizeTest.kt | Replaced expect function declaration with concrete implementation using kotlinx-resources |
| src/nonWasmTest/kotlin/NormalizeTest.nonWasm.kt | Removed platform-specific implementation (no longer needed) |
| src/wasmJsTest/kotlin/NormalizeTest.wasmJs.kt | Removed Wasm-specific implementation (no longer needed) |
| kotlin-js-store/yarn.lock | Updated JavaScript dependencies (karma, kotlin-web-helpers, mocha, webpack, enhanced-resolve) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
That certainly makes things a lot nicer! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Kotlin from 2.2.21 to 2.3.0 (required for kotlinx-resources 0.13.0) and update kotlinx-resources from 0.11.0 to 0.13.0 to get proper Wasm support. Simplify test source sets by removing nonWasmTest indirection. Now all platforms can use the same resource-loading mechanism, removing tons of embedded test data.