Cleanup project setup #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases this is stricter, and others are covered by Ruff.
These have long been replaced, mostly by Ruff.
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up long-deprecated configuration files and streamlines the CI workflows while converting many test functions to use explicit type annotations and updating the project configuration to enable most Ruff rules.
- Adds type annotations to numerous test functions
- Updates CI workflows to set up Python and Poetry from version files
- Refreshes pyproject.toml with updated Python version, description, keywords, and linter settings
Reviewed Changes
Copilot reviewed 23 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/utils/test_utils.py | Adds type annotations and imports |
| tests/test_models.py | Adds return type hints to test functions |
| tests/test_http_requests.py | Adds return type hints and renames a variable for clarity |
| tests/test_headers.py | Adds return type hints to test functions |
| tests/test_authentication.py | Adds return type hints to test functions |
| tests/test_api_tasks.py | Adds return type hints; renames "filter" to "filter_query" for clarity |
| tests/test_api_sections.py | Adds return type hints to test functions |
| tests/test_api_projects.py | Adds return type hints to test functions |
| tests/test_api_labels.py | Adds return type hints to test functions |
| tests/test_api_items.py | Adds type annotations to helper functions |
| tests/test_api_comments.py | Adds return type hints to test functions |
| tests/test_api_async.py | Adds return type hints to test functions |
| pyproject.toml | Updates project metadata, Python version, and linter configs |
| .github/workflows/publish.yml | Updates CI workflow to use dynamic Python/Poetry versions |
| .github/workflows/ci.yml | Updates CI workflow to use dynamic Python/Poetry versions |
Files not reviewed (5)
- .flake8: Language not supported
- .github/CODEOWNERS: Language not supported
- .isort.cfg: Language not supported
- .poetry-version: Language not supported
- mypy.ini: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was meant to be a small cleanup of long-deprecated config files (flake8, isort, etc, since replaced by ruff), but I ended up also enabling most Ruff rules and making the associated code changes, streamlining CI workflows, and a few other minor configuration improvements.
Best reviewed commit by commit.
I'll merge this once CI is green to continue iterating based on it, but do please take a look. I'm happy to iterate after the fact.