Use dataclasses_json for object mapping #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR integrates dataclasses_json for object mapping across various models, simplifying serialization code by removing custom from_dict/to_dict methods.
- Updated model classes to inherit from DataClassJsonMixin
- Removed custom serialization methods in favor of built-in functionality
- Updated tests, dependency definitions, and changelog accordingly
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| todoist_api_python/models.py | Replaces manual dict conversion with dataclasses_json mixin |
| tests/data/test_defaults.py | Updates URL default value for consistency |
| pyproject.toml | Adds dependency for dataclasses_json |
| CHANGELOG.md | Documents changes to serialization and fixes |
Member
Author
|
I'll merge this once CI is green to continue iterating based on it, but do please take a look. I'm happy to iterate after the fact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some changes and #163 would've had to be rebased, so I've done that here.