Skip to content

Conversation

@goncalossilva
Copy link
Member

As discussed on Twist a while ago. This is a good testing ground. :)

@goncalossilva goncalossilva requested review from Copilot and lefcha March 31, 2025 01:50
@goncalossilva goncalossilva requested a review from a team as a code owner March 31, 2025 01:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project from Poetry to uv for dependency management, building, and publishing. Key changes include updates to the pyproject.toml configuration, modifications to installation commands and supported Python versions in the README, and adjustments to pre-commit and GitHub workflows to use uv instead of Poetry.

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Migration of project metadata and dependencies from Poetry to uv
README.md Updated installation instructions and supported Python version
.pre-commit-config.yaml Added uv-specific hook and updated mypy command
.github/workflows/publish.yml Switched from Poetry to uv for the publishing workflow
.github/workflows/ci.yml Replaced Poetry with uv for CI steps
Files not reviewed (2)
  • .poetry-version: Language not supported
  • .python-version: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/publish.yml:20

  • Using pyproject.toml as the python-version-file might not yield the correct Python version since the file is a multi-purpose configuration file rather than a dedicated version file. Please verify that the setup-python action can correctly extract the version from this file.
          python-version-file: pyproject.toml

.github/workflows/ci.yml:17

  • Ensure that using pyproject.toml as the python-version-file works as expected, as it may not contain a simple version string required by the setup action.
          python-version-file: pyproject.toml

@goncalossilva goncalossilva merged commit 3a2ca78 into main Mar 31, 2025
1 check passed
@goncalossilva goncalossilva deleted the uv branch March 31, 2025 01:53
Copy link
Collaborator

@lefcha lefcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@goncalossilva
Copy link
Member Author

So far, so good. Poetry was fast, but this thing is basically instance. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants