Configure baseline timeouts for requests #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR configures a baseline timeout for API requests in order to prevent hanging connections. It adds a TIMEOUT constant to the HTTP requests module, updates get, post, and delete methods to apply the timeout, and documents the change in the CHANGELOG.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| todoist_api_python/http_requests.py | Adds a TIMEOUT constant and applies it to all session request methods. |
| CHANGELOG.md | Updates the changelog to reflect the new API timeout configuration. |
These represent a good baseline for 99.99% of cases. The remainder can customize the `Session` argument.
goncalossilva
force-pushed
the
goncalossilva/default-request-timeouts
branch
from
fce153d to
c4aea1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These represent a good baseline for the vast majority of cases, and the remainder can customize the
Sessionobject.We could provide ways to configure this, but seeing as the vast majority won't need it, I'd argue against complicating the SDK unnecessarily. As @rsyring said in #88, which I agree with:
Special cases can customize the
Sessionargument.Closes #88.