fix: map updated API task and project objects to match local schemas#283
Merged
Conversation
Member
|
Hi @luismpel, thanks for the contribution! I hope you don’t mind, but I pushed this commit directly to your branch. We’ll include this fix in the next patch release. That said, while the converter helpers you introduced help keep the library's API consistent, the following version will be a breaking release, aiming to align the library's task and project schemas with the respective Todoist API v1 objects. |
pedroalves0
changed the title
This was referenced Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This schema def fixes the issue I encountered when using GetProjects and better matches the API docs for the project response
This change makes tests in the repository fail.
Task entity also needs to be aligned
Maybe the typing needs to be adjusted. Only tested that it no longer threw Zod Errors.