Skip to content

Conversation

@Jessica-creat
Copy link
Contributor

Description

Ajout de classe api_holiday.class.php dans htdocs/holiday/class/.

Objectif

  • Fournir les fonctionnalités API liées aux congés (Holiday)
  • Introduire la logique métier pour la gestion des congés

Détails

  • api_holiday.class.php : endpoints REST de gestion des congés
  • holiday.class.php : modèle métier principal

@@ -0,0 +1,619 @@
<?php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a file htdocs/holiday/class/api_holidays.class.php that provide a read api, can you complete the existing file insted of adding a new one ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Charlène asked me to create a new api_hiliday.class.php because it doesn't existed, we probably do it it the same time xd so do you to keep yours or mine ? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry do you want to keep yours or mine ?

@eldy eldy added PR mixing structure and code change A PR with SQL addition must be pushed without code change. Split PR to submit structure only first. PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) and removed PR mixing structure and code change A PR with SQL addition must be pushed without code change. Split PR to submit structure only first. labels Nov 6, 2025
@eldy eldy added PR to fix - Conflict or CI error to solve The PHP unit tests return something wrong. Check details to know what to fix or solve the conflicts. and removed PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) labels Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR to fix - Conflict or CI error to solve The PHP unit tests return something wrong. Check details to know what to fix or solve the conflicts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants