NEW/FIX 32909 Add perm to modify HRM/salary information #36165
Conversation
| $this->rights[$r][self::KEY_ID] = 345; | ||
| $this->rights[$r][self::KEY_LABEL] = 'Modify its own HRM/salary informations'; | ||
| $this->rights[$r][self::KEY_DEFAULT] = 0; | ||
| $this->rights[$r][self::KEY_FIRST_LEVEL] = 'self_advance'; // Visible if option MAIN_USE_ADVANCED_PERMS is on |
There was a problem hiding this comment.
We need such a permission. However, i think it is better to have it handled by the module HR (Human resources). If module is not enabled, we keep current code (we don't want human resource management so we don't want powerful salary management), but if enable the HR module, we use this permission to know if wa can write salary information. Because when we enable the module HR, it means we want a powerfull manager of salary. In this case, we can use a "common" permission (not need for advanced permission) because it is the "common need" of HR module.
So I suggest to move this permission into the module HRM instead of module user.
It could be
$this->rights[$r][self::KEY_FIRST_LEVEL] = 'write_salary';
$this->rights[$r][self::KEY_SECON_LEVEL] = 'write';
Can you modify your PR in this direction ?
There was a problem hiding this comment.
After a more complete analysis, it seems there is already a permission on salary information, hosted by the module salary.
Can you check if we still need such a pr ?
Or if enabling the module salary is enough to protect salary information ?
There was a problem hiding this comment.
I could handle it. I just need to find some time :-)
eldy
added
the
Discussion
2 participants
NEW/FIX 32909 Add perm to modify HRM/salary information
NEW
Add perm to modify HRM/salary information :
FIX
The user, without right on his employee card, could change his salary.
(only visually, there was no basic change)