Feat/add holidays classes #36287
Open
Feat/add holidays classes #36287
+623
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
added
the
PR to fix - Conflict or CI error to solve
- Add complete REST API for holiday management - Implement CRUD operations (GET, POST, PUT, DELETE) - Add status transition endpoints (validate, approve, cancel, refuse) - Include holiday types and balance management - Enhance Holiday class with additional validations and methods - Add pagination and filtering support - Improve error handling and data validation
Jessica-creat
force-pushed
the
feat/add-holidays-classes
branch
from
eda4358 to
61a3769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement comprehensive REST API for holiday management with full CRUD operations and status transitions.
Changes
Features Added
API Endpoints
GET /holidays- List holidays with filtersPOST /holidays- Create new holidayGET /holidays/{id}- Get specific holidayPUT /holidays/{id}- Update holidayDELETE /holidays/{id}- Delete holidayPOST /holidays/{id}/validate- Validate holidayPOST /holidays/{id}/approve- Approve holidayPOST /holidays/{id}/cancel- Cancel holidayPOST /holidays/{id}/refuse- Refuse holidayGET /holidays/types- Get holiday typesGET /holidays/balance- Get user balanceTesting
The implementation includes comprehensive error handling and can be tested using standard REST API clients.