Skip to content

Conversation

@atm-corentin
Copy link
Contributor

@atm-corentin atm-corentin commented Nov 18, 2025

NEW|New add drag-and-drop functionality for managing draft expedition lines

We keep the standard drag-and-drop workflow (ajaxrow.tpl, tdlineupdown column, /core/ajax/row.php), so the user experience matches what you get on quotes/orders/invoices.

  1. Shipments have one peculiarity: a single visible line can represent several llx_expeditiondet rows (multi-warehouse/lot). We therefore override Expedition so that reordering a line updates every sub-line sharing the same fk_origin_line, and fetch_lines() now sorts by ed.rang to mirror the stored order. row.php instantiates Expedition whenever table_element_line=expeditiondet, letting the existing AJAX flow trigger these overrides without any frontend changes.

@atm-corentin atm-corentin requested a review from eldy November 19, 2025 13:20
@eldy eldy added the PR to fix - Conflict or CI error to solve The PHP unit tests return something wrong. Check details to know what to fix or solve the conflicts. label Nov 19, 2025
@atm-corentin
Copy link
Contributor Author

@eldy, I don't know how to fix that because it's an override and the default method doesn't have a type

@hregis
Copy link
Contributor

hregis commented Nov 24, 2025

@atm-corentin try to replace

@param array $rows

by

@param int[] $rows

@atm-corentin
Copy link
Contributor Author

@eldy thanks it's good now

@atm-corentin atm-corentin removed the PR to fix - Conflict or CI error to solve The PHP unit tests return something wrong. Check details to know what to fix or solve the conflicts. label Nov 24, 2025
@eldy eldy added the PR postponed PR is postponed (will be processed later). Ie: pushed during/near a beta, or need transition delay label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR postponed PR is postponed (will be processed later). Ie: pushed during/near a beta, or need transition delay

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants