FIX: TakePos sometimes thirdpartyid = undefined#36343
Merged
rycks merged 4 commits intoDolibarr:18.0from Jan 8, 2026
Merged
Conversation
the-dolibear-bot-for-v18
bot
added
the
Issue for v18 maintenance Team
the-dolibear-bot-for-v18
bot
requested review from
lvessiller-opendsi and
rycks
eldy
reviewed
Nov 20, 2025
eldy
added
the
PR to fix - See feedback in comments
lvessiller-opendsi
requested changes
Nov 27, 2025
lvessiller-opendsi
requested changes
Dec 4, 2025
the-dolibear-bot-for-v18
bot
requested review from
lvessiller-opendsi and
rycks
lvessiller-opendsi
approved these changes
Dec 11, 2025
rycks
approved these changes
Dec 11, 2025
lvessiller-opendsi
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to 36341
Sometimes jQuery('#thirdpartyid').val() is undefined because the input is described in takepos/invoice.php.
But it needs to be defined before, to prevent wrong price to be fetched in case of multilevel prices.