Qual: Undefined variable $errormessage in /var/www/html/core/customreports.php on line 951 #36392

JonBendtsen · 2025-11-23T22:02:20Z

Qual Undefined variables in /var/www/html/core/customreports.php on various lines

This PR is a fix of an error message discovered during my exploring of a fix of BI - Custom Reports "Warning: Undefined property: CLeadStatus::$fields in bug nr. 35096

JonBendtsen · 2025-11-23T22:24:01Z

commit fixes

PHP Warning:  Attempt to read property "table_element" on null in /var/www/html/core/customreports.php on line 204
PHP Warning:  Attempt to read property "element" on null in /var/www/html/core/customreports.php on line 312
PHP Warning:  Attempt to read property "element" on null in /var/www/html/core/customreports.php on line 1136
PHP Warning:  Attempt to read property "element" on null in /var/www/html/core/customreports.php on line 1137

JonBendtsen · 2025-11-23T22:24:42Z

htdocs/core/customreports.php

+if (!empty($object->table_element)) {
+	$search_array_options = $extrafields->getOptionalsFromPost($object->table_element, '', 'search_');
+} else {
+	$search_array_options = array();


idea copied from

htdocs/core/lib/company.lib.php: $search_array_options = array();

JonBendtsen · 2025-11-23T22:25:03Z

htdocs/core/customreports.php

+	$features = $object->element;
+} else {
+	$features = '';
+}


unsure if the variable should be empty

JonBendtsen · 2025-11-23T22:25:56Z

htdocs/core/customreports.php

+		if (isset($filenamekey) && isset($fileurlkey)) {
+			$px1->draw($filenamekey, $fileurlkey);
+		}



Unsure if it is better to assign these $filenamekey and $fileurlkey to an empty string and then draw that

hregis · 2025-11-23T22:31:36Z

@JonBendtsen object "element" and " table_element" can not be empty ! if empty... buuuugs in class of element !

JonBendtsen · 2025-11-23T22:35:01Z

@JonBendtsen object "element" and " table_element" can not be empty ! if empty... buuuugs in class of element !

Okay, then I don't know how to fix it.

I get those 4 PHP warning lines when switching to Predefined Invoices on this page /core/customreports.php

hregis · 2025-11-23T22:43:29Z

@JonBendtsen and with this fixx: #36393 ?

JonBendtsen · 2025-11-24T17:56:54Z

eldy's fix here 112028a works fine so I will close this PR

JonBendtsen · 2025-11-24T17:58:58Z

damn, tested in the wrong branch

JonBendtsen · 2025-11-24T18:00:41Z

first commit fixes error message like this

192.168.127.1 - - [24/Nov/2025:18:58:14 +0100] "POST /core/ajax/check_notifications.php HTTP/1.1" 200 419 "http://localhost:20080/core/customreports.php?objecttype=proposal" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Safari/537.36"
[Mon Nov 24 18:58:16.685442 2025] [php:warn] [pid 49:tid 49] [client 192.168.127.1:58771] PHP Warning:  Undefined variable $errormessage in /var/www/html/core/customreports.php on line 951, referer: http://localhost:20080/core/customreports.php?objecttype=proposal
192.168.127.1 - - [24/Nov/2025:18:58:16 +0100] "GET /core/customreports.php?objecttype=order HTTP/1.1" 200 23592 "http://localhost:20080/core/customreports.php?objecttype=proposal" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Safari/537.36"
192.168.127.1 - - [24/Nov/2025:18:58:19 +0100] "POST /core/ajax/check_notifications.php HTTP/1.1" 200 419 "http://localhost:20080/core/customreports.php?objecttype=order" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Safari/537.36"
[Mon Nov 24 18:58:20.107309 2025] [php:warn] [pid 49:tid 49] [client 192.168.127.1:58771] PHP Warning:  Undefined variable $errormessage in /var/www/html/core/customreports.php on line 951, referer: http://localhost:20080/core/customreports.php?objecttype=order

JonBendtsen · 2025-11-24T18:03:21Z

if I only use @eldy's fix in 112028a I still get the errors I post in this PR, but with the changes here and @eldy's changes in 112028a both in v20 with commit

commit b9e6243ec8eef181f2d52884817c476514231460 (HEAD -> 20.0, origin/20.0)
Merge: 0e8d4461c4f 9394f24cf7f
Author: Laurent Destailleur <[email protected]>
Date:   Mon Nov 24 16:16:00 2025 +0100

    Merge branch '19.0' of [email protected]:Dolibarr/dolibarr.git into 20.0

I do not get any errors.

@eldy do you want your fix in v22 backported into v20 in this PR?, if not you can just go ahead and merge this

hregis · 2025-11-24T18:12:18Z

@JonBendtsen #36393

eldy · 2025-11-24T18:28:24Z

customreports feature seams still in development in v20.
note that warning on $errormesssage was fixed with commit 71dc6dc

JonBendtsen · 2025-11-24T18:32:39Z

@JonBendtsen #36393

that one is closed @hregis ?

JonBendtsen · 2025-11-24T18:45:18Z

customreports feature seams still in development in v20. note that warning on $errormesssage was fixed with commit 71dc6dc

even with fresh pulled v20, and your changes backported from 112028a

I still get these errors when selecting Predefined Invoices in the dropdown.

[Mon Nov 24 19:43:13.921859 2025] [php:warn] [pid 45:tid 45] [client 192.168.127.1:32510] PHP Warning:  Attempt to read property "table_element" on null in /var/www/html/core/customreports.php on line 205, referer: http://localhost:20080/core/customreports.php?objecttype=cotisation
[Mon Nov 24 19:43:13.921989 2025] [php:warn] [pid 45:tid 45] [client 192.168.127.1:32510] PHP Warning:  Attempt to read property "element" on null in /var/www/html/core/customreports.php on line 313, referer: http://localhost:20080/core/customreports.php?objecttype=cotisation
[Mon Nov 24 19:43:13.966225 2025] [php:warn] [pid 45:tid 45] [client 192.168.127.1:32510] PHP Warning:  Attempt to read property "element" on null in /var/www/html/core/customreports.php on line 1137, referer: http://localhost:20080/core/customreports.php?objecttype=cotisation
[Mon Nov 24 19:43:13.966248 2025] [php:warn] [pid 45:tid 45] [client 192.168.127.1:32510] PHP Warning:  Attempt to read property "element" on null in /var/www/html/core/customreports.php on line 1138, referer: http://localhost:20080/core/customreports.php?objecttype=cotisation

JonBendtsen · 2025-11-24T18:51:16Z

@eldy after testing with the changes here in this PR I get no errors in Predefined Invoices

JonBendtsen · 2025-11-24T18:52:03Z

@eldy if you want I can easily add you changes backported to v20

JonSweet16:20.0 jonbendtsen$ git add -p
diff --git a/htdocs/core/class/cleadstatus.class.php b/htdocs/core/class/cleadstatus.class.php
index f72f9dddc7d..7f6c0b9d0da 100644
--- a/htdocs/core/class/cleadstatus.class.php
+++ b/htdocs/core/class/cleadstatus.class.php
@@ -57,6 +57,10 @@ class CLeadStatus extends CommonDict
 	 */
 	public $percent;
 
+	public $fields = array(
+		'rowid' => array('type' => 'integer', 'label' => 'TechnicalID', 'enabled' => 1, 'position' => 1, 'notnull' => 1, 'visible' => 0, 'noteditable' => 1, 'index' => 1, 'css' => 'left', 'comment' => "Id"),
+		'label' => array('type' => 'varchar(128)', 'label' => 'Label', 'enabled' => 1, 'position' => 20, 'notnull' => 1, 'visible' => 1, 'index' => 1, 'searchall' => 1, 'showoncombobox' => 1, 'comment' => "Label of status"),
+	);
 
 	/**
 	 *  Constructor
(1/1) Stage this hunk [y,n,q,a,d,e,p,?]? n

eldy · 2025-11-24T20:11:53Z

@eldy if you want I can easily add you changes backported to v20

JonSweet16:20.0 jonbendtsen$ git add -p
diff --git a/htdocs/core/class/cleadstatus.class.php b/htdocs/core/class/cleadstatus.class.php
index f72f9dddc7d..7f6c0b9d0da 100644
--- a/htdocs/core/class/cleadstatus.class.php
+++ b/htdocs/core/class/cleadstatus.class.php
@@ -57,6 +57,10 @@ class CLeadStatus extends CommonDict
 	 */
 	public $percent;
 
+	public $fields = array(
+		'rowid' => array('type' => 'integer', 'label' => 'TechnicalID', 'enabled' => 1, 'position' => 1, 'notnull' => 1, 'visible' => 0, 'noteditable' => 1, 'index' => 1, 'css' => 'left', 'comment' => "Id"),
+		'label' => array('type' => 'varchar(128)', 'label' => 'Label', 'enabled' => 1, 'position' => 20, 'notnull' => 1, 'visible' => 1, 'index' => 1, 'searchall' => 1, 'showoncombobox' => 1, 'comment' => "Label of status"),
+	);
 
 	/**
 	 *  Constructor
(1/1) Stage this hunk [y,n,q,a,d,e,p,?]? n

You can. Not required as it is is not supported feature in v20. But you can.

JonBendtsen commented Nov 23, 2025

View reviewed changes

JonBendtsen closed this Nov 24, 2025

JonBendtsen reopened this Nov 24, 2025

JonBendtsen force-pushed the BICustomReportsWarningUndefinedpropertyCLeadStatusfields35096 branch from 6bf7195 to ef70a7a Compare November 24, 2025 18:03

eldy closed this Nov 24, 2025

eldy reopened this Nov 24, 2025

Jon Bendtsen added 2 commits November 24, 2025 19:46

checking if variable is set before testing the contents

eab145a

more PHP warnings fixes detected during Dolibarr#35096

6e111fe

JonBendtsen force-pushed the BICustomReportsWarningUndefinedpropertyCLeadStatusfields35096 branch from ef70a7a to 6e111fe Compare November 24, 2025 18:46

using the fixed set above

33c7419

backport eldy's fix

ed25e9a

JonBendtsen marked this pull request as ready for review November 24, 2025 21:56

Uh oh!

Qual: Undefined variable $errormessage in /var/www/html/core/customreports.php on line 951 #36392

Are you sure you want to change the base?

Qual: Undefined variable $errormessage in /var/www/html/core/customreports.php on line 951 #36392

Conversation

JonBendtsen commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qual Undefined variables in /var/www/html/core/customreports.php on various lines

Uh oh!

JonBendtsen commented Nov 23, 2025

Uh oh!

JonBendtsen Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

JonBendtsen Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

JonBendtsen Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

hregis commented Nov 23, 2025

Uh oh!

JonBendtsen commented Nov 23, 2025

Uh oh!

hregis commented Nov 23, 2025

Uh oh!

JonBendtsen commented Nov 24, 2025

Uh oh!

JonBendtsen commented Nov 24, 2025

Uh oh!

JonBendtsen commented Nov 24, 2025

Uh oh!

JonBendtsen commented Nov 24, 2025

Uh oh!

hregis commented Nov 24, 2025

Uh oh!

eldy commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonBendtsen commented Nov 24, 2025

Uh oh!

JonBendtsen commented Nov 24, 2025

Uh oh!

JonBendtsen commented Nov 24, 2025

Uh oh!

JonBendtsen commented Nov 24, 2025

Uh oh!

eldy commented Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JonBendtsen commented Nov 23, 2025 •

edited

Loading

eldy commented Nov 24, 2025 •

edited

Loading