new : api setup - Add dictionnary holiday lists #36402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defrance
commented
Nov 24, 2025
Contributor
Author
defrance
left a comment
defrance
left a comment
There was a problem hiding this comment.
del white spaces
Member
|
Whe should have (like we should for all endpoints for holiday) one test on permission For example, i the same api file for diction of proposal, we have |
eldy
added
the
PR to fix - See feedback in comments
Added permission checks for user access rights before fetching data for expense reports, holidays, and HR public holidays.
defrance
commented
Nov 24, 2025
Contributor
Author
defrance
left a comment
defrance
left a comment
There was a problem hiding this comment.
added on expensereport dictionary api too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list of defined holiday and list of public holiday