Skip to content

Add strong naming #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add strong naming #616

wants to merge 1 commit into from

Conversation

ilCosmico
Copy link

Description

This pull request introduces strong-name signing to allow seamless integration of ACadSharp into signed projects, avoiding runtime issues caused by unsigned assemblies.

Tasks done in this PR

  • Code cleanup and maintenance has been done.
  • Strong-name key file added and signing enabled in .csproj.

Notes for reviewer

  • No functional changes have been introduced.
  • The strong-name key used is a default developer key (.snk) and can be replaced with an official one if needed.

This pull request introduces strong-name signing to allow seamless integration of ACadSharp into signed projects, avoiding runtime issues caused by unsigned assemblies.
@DomCR
Copy link
Owner

DomCR commented Apr 23, 2025

Hi @ilCosmico,

Thanks for posting this PR, I have to consider the changes and what they imply to the project.

I'll come back to this one, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants