Skip to content

MultiLeader SPIKE #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

MultiLeader SPIKE #641

wants to merge 9 commits into from

Conversation

DomCR
Copy link
Owner

@DomCR DomCR commented Apr 27, 2025

Description

Investigation for MLeader objects not being correctly read by the DwgReader and written by DwgWriter.

Tasks done in this PR

Notes for reviewer

  • After reading the OpenDesign docs I've found some errors in the code; a missing flag version and some wrongly read values that where read in the wrong format.
  • The flag set as IF IsNewFormat OR DXF file has been removed because it was set as R2010 instead of a value in the APPID “ACAD_MLEADERVER”. This change seems to fix the older versions of the dwg but the value still is unknown for the reader and in some cases may cause to trigger an exception in the reader (not a breaking change if the Failsafe is on).
  • The last bit UnknownFlag298 seems to be present only for R2013Plus versions of dwg, this has been found by a manual investigation which may be wrongly assumed, to avoid the wrong values it will be set as an internal value.

@DomCR DomCR added enhancement New feature or request SPIKE Investigation related labels Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SPIKE Investigation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant