Proposed fixes for #672 #673
Conversation
- setter of dimension Block adds new BlockRecord with unique name. - Block property writes handle.
src/ACadSharp/IO/DWG/DwgStreamWriters/DwgObjectWriter.Entities.cs
Outdated
Show resolved
Hide resolved
| @@ -280,5 +283,35 @@ protected override void tableOnRemove(object sender, CollectionChangedEventArgs | |||
| this._block = null; | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| private void addToBlockRecordsTable(BlockRecord block) | |||
There was a problem hiding this comment.
I don't think that's a good practice to make changes to an object that is not managed by the library itself, I would suggest to keep the old method updateTable and add a guard that check that the block has the flag anonymous set.
If the naming of the block is an issue for any software, we can add a method that specifically changes the block name to a unique one for the current dimension, or a method in the CadDocument that updates the name for all anonymous blocks.
There was a problem hiding this comment.
I think the uniqueness of the name is essential for ACadSharp.
updateTable tries to find a BlockRecord with the same name and returns the existing one so that the new one is to be discarded. We have to ensure that the new one is kept - with a new name.
Example:
I cloned Dimension objects from various source DWGs to a new document. They accidenially had the same "*D..." names. Effectively I had more than one Dimension object that were completely different referencing the same BlockRecord.
see #672.