Backports fixes #1 #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 9, 2014 15:35
…Attempts to get a long with EEPROM_CHITCHAT from Marlin Firmware
Member
|
Hi @morriswinkler, we appreciate the work, but I'm afraid we need to find a different solution to support printers with chitchat enabled. When it takes 45 attempts before a printer switches baudrate the baudrate detection takes to long. |
Author
|
ok let me see if i can figure out a way to detect chitchat, i guess shouldn't be difficult, i don't know if i can do it this week, but i will try as soon as possible,,. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1 and increases maxCheckTemperatureAttempts_ to 45 in src/drivers/MarlinDriver.cpp so it will connect even if EEPROM_CHITCHAT is defined in the Configuration.h of the Marlin firmware.