Revamp chat sounds #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cher-nov
requested changes
Jun 4, 2025
cher-nov
requested changes
Jun 5, 2025
gena-nosov
added a commit
to Jabberwock-RU/DF-Assets
that referenced
this pull request
Jun 5, 2025
Taken from: Doom2D#16 (comment) Also make its name more clear.
gena-nosov
force-pushed
the
gachi2
branch
2 times, most recently
from
2e6f75a to
6d5d667
Compare
cher-nov
requested changes
Jun 6, 2025
There was a problem hiding this comment.
Could you please also merge the "Game: add "Эй, народ, я пришёл" sound" commit with the last one?
- They have the same description.
- It would be nice not to interrupt housekeeping with adding new assets.
- This would bring new
SETUP_TESTtags closer in order to the current ones.
Also I think we can safely remove ATAMSCHU.wav, OTOMSTIT.wav and KOMNE.wav. The first one duplicates the sound of the default skin, while other are simply off the point.
cher-nov
reviewed
Jun 6, 2025
gena-nosov
added a commit
to Jabberwock-RU/DF-Assets
that referenced
this pull request
Jun 6, 2025
Taken from: Doom2D#16 (comment)
|
One of points of the game chat sounds addition was to extend self-expression possibilities for the players, including the possibility to put audible emotional pressure on each other using certain sounds at the right moment in a network game. Slight offensiveness of some sounds is possible, without exceeding the permissible limit. Most of them are references to known memes and games. |
cher-nov
requested changes
Jun 6, 2025
gena-nosov
added a commit
to Jabberwock-RU/DF-Assets
that referenced
this pull request
Jun 6, 2025
Taken from: Doom2D#16 (comment)
cher-nov
requested changes
Jun 10, 2025
There was a problem hiding this comment.
- Typo: "thta" ("that") in description of "Game: rename TEST1 -> SETUP_TEST".
- Please add "кайф" to HOROSHO, and remove "отлично" as it is superlative degree.
- Please add "так точно" to YESSIR and remove "йее" (as unrelated), "yes" and "ага" (as in general use).
- Note in the commit message that YESSIR you made is neuro-modified for noise reduction, and specify the exact service/model you used.
This makes it more clear that this sound came from Doom2D setup.
Taken from: Doom2D#16 (comment)
As discussed here: https://t.me/doom2d/494393 YESSIR sound was artificially modified to reduce background noise. Tool used: https://voice.ai/tools/vocal-remover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.