[FEAT] 체크리스트 기반 방 필터링 조회 쿼리 최적화#88
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Template
📌 제목
📢 요약
🔗 연관 이슈: Resolves #이슈번호
🚀 PR 유형
✅ PR 체크리스트
📜 기타
변경 배경
room과room_rule를 직접 결합한 구조로 동작해, 일부 정렬 시나리오에서 PostgreSQL이 비효율적인 실행 계획을 선택할 여지가 있었습니다.remaining정렬에서는 체크리스트 조건과 정렬 조건이 함께 적용되며Sort와 늦은LIMIT적용이 발생할 수 있어, 최악 구간의 성능 저하 가능성이 있었습니다.주요 변경 사항
JOIN LATERAL기반 구조로 재구성해 방 테이블을 먼저 탐색하고 각 방마다 체크리스트 일치 여부를 확인하도록 변경했습니다.remaining정렬은 커서 기준을 함께 조정해 정렬 순서와 페이징 기준이 일치하도록 맞췄습니다.remaining값을 포함하도록 변경해 커서 생성과 다음 페이지 판단이 정렬 기준과 일관되게 동작하도록 수정했습니다.테스트 및 검증
remaining정렬 커서 처리, 응답 생성 흐름이 기존과 다르게 깨지지 않도록 검증했습니다.참고