Feat/update sass usage #2989
Open
Feat/update sass usage #2989
+4,561
−4,170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2025 17:00
Change-Id: I92efedbd9d0a2c9de81445c818268c5291af0e8b
Change-Id: I0baceaff838404aed8b88fa5d7cbf5eedfb81aed
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 00d807b:
|
YyumeiZhang
reviewed
Jan 5, 2026
| @@ -1,3 +1,5 @@ | |||
| @use '../../semi-theme-default/scss/index.scss' as *; | |||
Collaborator
There was a problem hiding this comment.
不用直接导入 semi-theme-default 中的 scss ，因为 Semi 支持用户使用自定义主题，原来的逻辑是在 semi-theme-loader 中使用将默认主题主题/自定义主题的/scss/index.scss 插入到 scss 文件中。因此应该考虑修改 semi-theme-loader 的逻辑而不是直接在这里手动添加
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
Fixes #
Changelog
🇨🇳 Chinese
🇺🇸 English
Checklist
Other
Additional information