Skip to content

Conversation

@YannLynn
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • [] Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

根据 DSM 中组件级 token 修改频率,选取了 10 个高频修改组件进行 token 描述优化,主要有以下几大类问题

  • Token 定义了但是实际未被真实使用,需要删除
  • Token 描述不够准确,不好被设计师理解
  • Token 注释有误,完全不符合 token 定义

Changelog

🇨🇳 Chinese

  • Docs: 优化 Button、Select、Checkbox、Input、Radio、Switch、Tabs、Navigation、Cascader、Table、Datepicker、Upload 等 10 枚组件的 token 描述

🇺🇸 English

  • Docs: Optimized token descriptions for 10 components including Button, Select, Checkbox, Input, Radio, Switch, Tabs, Navigation, Cascader, Table, Datepicker, and Upload.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@YannLynn YannLynn requested a review from YyumeiZhang November 25, 2025 09:51
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 25, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d83aab8:

Sandbox Source
pr-story Configuration

@cypress
Copy link

cypress bot commented Nov 25, 2025

semi-design    Run #3428

Run Properties:  status check passed Passed #3428  •  git commit 952d15f4ca ℹ️: Merge d83aab8b9be299d70899e96c38cbfa3d3ff246e6 into f6ee410d7f92d32470da872d7061...
Project semi-design
Branch Review update-token-desc
Run status status check passed Passed #3428
Run duration 08m 15s
Commit git commit 952d15f4ca ℹ️: Merge d83aab8b9be299d70899e96c38cbfa3d3ff246e6 into f6ee410d7f92d32470da872d7061...
Committer YannLynn
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 13
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 291
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

$color-select_option-icon-default: transparent; // 选择器下拉菜单选项图标颜色 - 默认态
$color-select_option-bg-hover: var(--semi-color-fill-0); // 选择器下拉菜单选项背景颜色 - 悬停态
$color-select_option-bg-active: var(--semi-color-fill-1); // 选择器下拉菜单选项背景颜色 - 按下态
$color-select_option_disabled-text: var(--semi-color-disabled-text); // 禁用选择器下拉菜单选项文字颜色
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

禁用移到选项之前?禁用的是选项,不是选择器

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

搜了下这个 token 没有被用到,我先注释掉吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants