Fixes for #53#57
Conversation
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
DrKJeff16
force-pushed
the
patch/documentation
branch
from
7ffc46a to
17fc406
Compare
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
DrKJeff16
added
documentation
| --- --- | ||
| ---Note that blinking is no longer a binary blink, but interpolates | ||
| ---between invisible and visible text using an easing function. | ||
| ---See `text_blink_rapid_ease_in` and `text_blink_rapid_ease_out` | ||
| ---for more information. |
There was a problem hiding this comment.
I don't know what to do about these 'Notes' parts where Wez is giving an update about how things have changed from previous versions. I've just been incorporating those notes into the docs because I don't like having to read all the way to bottom of the documentation page to see what the 'latest' change to this option/value is, I'd rather see that up front. My opinion is that when we see these sort of 'update for version 2024...' additions, we just incorporate those notes and adjust the annotations/docs accordingly. What do you think? This can be a TODO for sometime later, I don't want to hold up this PR for it!
There was a problem hiding this comment.
Yeah, the trick's to integrate these "version updates" seamlessly in the annotations.
I found for now just to add a horizontal ruler (---) just as a compromise,
but if we can manage to find a better solution I'm all for it.
| --- | ||
| ---@field treat_left_ctrlalt_as_altgr? boolean | ||
| ---The set of unix domains | ||
| ---The set of UNIX domains. |
There was a problem hiding this comment.
Good catch! I noticed this in at least 1 or 2 other places, let's fix 'em as we see them.
| --- --- | ||
| ---Note that blinking is no longer a binary blink, but interpolates | ||
| ---between invisible and visible text using an easing function. | ||
| ---See `text_blink_rapid_ease_in` and `text_blink_rapid_ease_out` |
There was a problem hiding this comment.
Another TODO maybe: I haven't tried them yet but I wonder if we could make use of the referring to symbols feature so they could be clickable links? I'm not sure if they even work in neovim or how they render, just a thought!
There was a problem hiding this comment.
Does this feature apply to ---@field annotations?
craigmac
left a comment
craigmac
left a comment
There was a problem hiding this comment.
Looks great thanks! I'll open the possible TODOs as separate issues.
|
@craigmac Oh man, just when we were talking about Neovim's renderng: this happens lol |
Interesting! I'll watch it's progress. |
2 participants
Changes
Same as #53 plus the following: