-
Notifications
You must be signed in to change notification settings - Fork 206
Feature: Conditions rewrite #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
external was a legacy feature that you link data from your app to the internals of formeo. this functionality can be replicated with better effect using actions and events so the feature was removed to reduce complexity BREAKING CHANGE: removes external data support from form config
external was a legacy feature that you link data from your app to the internals of formeo. this functionality can be replicated with better effect using actions and events so the feature was removed to reduce complexity BREAKING CHANGE: removes external data support from form config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive rewrite of the form field conditions system to improve reliability and usability. The changes standardize condition matching logic, consolidate the conditions UI into stage configuration, and enhance visual feedback through color-coded components. The rewrite also includes significant refactoring of component architecture, improved data management, and enhanced type safety.
Key changes include:
- Complete rewrite of conditions logic with new autocomplete system and UI
- Refactored component architecture with consolidated edit panels and improved data flow
- Enhanced styling with component-specific color coding and improved visual hierarchy
Reviewed Changes
Copilot reviewed 101 out of 108 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/lib/js/renderer/index.js |
Refactored condition evaluation and form rendering with new property mapping system |
src/lib/js/renderer/helpers.js |
New helper file extracting condition-related utilities and property handlers |
src/lib/js/components/edit-panel/ |
New directory with modular condition editing components |
src/lib/js/components/autocomplete/ |
Restructured autocomplete with improved component highlighting and option handling |
src/lib/js/constants.js |
Expanded constants for conditions, component types, and property mappings |
src/lib/sass/components/_field-edit.scss |
Extensive styling updates for condition UI with improved layout and visual feedback |
vite.config.lib.mjs, tools/ |
Code formatting improvements and consistent styling |
Comments suppressed due to low confidence (1)
tools/generate-json-schema.ts:1
- The biome-ignore comment was removed but the 'then' property is still used as an object key below (line 135). If this is intentional and 'then' as a key is now acceptable, this is fine. Otherwise, the ignore directive should be retained.
import { writeFileSync } from 'node:fs'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Problem:
Solution: