Skip to content

Conversation

@kevinchappell
Copy link
Collaborator

Problem:

  • form field conditions do not always work as intended
  • the conditions UI is cramped and sometimes difficult to locate.

Solution:

  • standardize condition matching and results
  • consolidate condition UI to the Stage config rather than spread across, rows, columns and fields.
  • improve usability by color coding components

external was a legacy feature that you link data from your app to the internals of formeo. this functionality can be replicated with better effect using actions and events so the feature was removed to reduce complexity

BREAKING CHANGE: removes external data support from form config
external was a legacy feature that you link data from your app to the internals of formeo. this functionality can be replicated with better effect using actions and events so the feature was removed to reduce complexity

BREAKING CHANGE: removes external data support from form config
@kevinchappell kevinchappell marked this pull request as ready for review November 5, 2025 16:21
Copilot AI review requested due to automatic review settings November 5, 2025 16:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive rewrite of the form field conditions system to improve reliability and usability. The changes standardize condition matching logic, consolidate the conditions UI into stage configuration, and enhance visual feedback through color-coded components. The rewrite also includes significant refactoring of component architecture, improved data management, and enhanced type safety.

Key changes include:

  • Complete rewrite of conditions logic with new autocomplete system and UI
  • Refactored component architecture with consolidated edit panels and improved data flow
  • Enhanced styling with component-specific color coding and improved visual hierarchy

Reviewed Changes

Copilot reviewed 101 out of 108 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/lib/js/renderer/index.js Refactored condition evaluation and form rendering with new property mapping system
src/lib/js/renderer/helpers.js New helper file extracting condition-related utilities and property handlers
src/lib/js/components/edit-panel/ New directory with modular condition editing components
src/lib/js/components/autocomplete/ Restructured autocomplete with improved component highlighting and option handling
src/lib/js/constants.js Expanded constants for conditions, component types, and property mappings
src/lib/sass/components/_field-edit.scss Extensive styling updates for condition UI with improved layout and visual feedback
vite.config.lib.mjs, tools/ Code formatting improvements and consistent styling
Comments suppressed due to low confidence (1)

tools/generate-json-schema.ts:1

  • The biome-ignore comment was removed but the 'then' property is still used as an object key below (line 135). If this is intentional and 'then' as a key is now acceptable, this is fine. Otherwise, the ignore directive should be retained.
import { writeFileSync } from 'node:fs'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kevinchappell kevinchappell merged commit 4090dee into master Nov 5, 2025
2 checks passed
@kevinchappell kevinchappell deleted the fix/condition-styles branch November 5, 2025 16:43
@kevinchappell
Copy link
Collaborator Author

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants