-
Notifications
You must be signed in to change notification settings - Fork 206
docs: add missing callback options to events documentation table #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: kevinchappell <[email protected]>
kevinchappell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses feedback from PR #411 by adding documentation for six missing callback options related to adding and removing rows, columns, and fields in the events system.
- Adds
onAddRow,onAddColumn,onAddFieldcallback documentation - Adds
onRemoveRow,onRemoveColumn,onRemoveFieldcallback documentation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | `onUpdateColumn` | Function | Fires when column is updated | | ||
| | `onUpdateField` | Function | Fires when field is updated | | ||
| | `onAddRow` | Function | Fires when row is added | | ||
| | `onAddColumn` | Function | Fires when column is added | | ||
| | `onAddField` | Function | Fires when field is added | | ||
| | `onRemoveRow` | Function | Fires when row is removed | | ||
| | `onRemoveColumn` | Function | Fires when column is removed | |
Copilot
AI
Nov 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The ordering of these callback options doesn't match the pattern used in the "Available DOM Events" section below (lines 81-90). For consistency, consider grouping by component type instead of by operation type.
For example:
| `onUpdateRow` | Function | Fires when row is updated |
| `onAddRow` | Function | Fires when row is added |
| `onRemoveRow` | Function | Fires when row is removed |
| `onUpdateColumn` | Function | Fires when column is updated |
| `onAddColumn` | Function | Fires when column is added |
| `onRemoveColumn` | Function | Fires when column is removed |
| `onUpdateField` | Function | Fires when field is updated |
| `onAddField` | Function | Fires when field is added |
| `onRemoveField` | Function | Fires when field is removed |
This would match the DOM Events table structure and make it easier for users to find related callbacks.
| | `onUpdateColumn` | Function | Fires when column is updated | | |
| | `onUpdateField` | Function | Fires when field is updated | | |
| | `onAddRow` | Function | Fires when row is added | | |
| | `onAddColumn` | Function | Fires when column is added | | |
| | `onAddField` | Function | Fires when field is added | | |
| | `onRemoveRow` | Function | Fires when row is removed | | |
| | `onRemoveColumn` | Function | Fires when column is removed | | |
| | `onAddRow` | Function | Fires when row is added | | |
| | `onRemoveRow` | Function | Fires when row is removed | | |
| | `onUpdateColumn` | Function | Fires when column is updated | | |
| | `onAddColumn` | Function | Fires when column is added | | |
| | `onRemoveColumn` | Function | Fires when column is removed | | |
| | `onUpdateField` | Function | Fires when field is updated | | |
| | `onAddField` | Function | Fires when field is added | |
The "Available Callback Options" table was missing six callback functions added in commit 48531fc.
Changes:
onAddRow,onAddColumn,onAddFieldto documentation tableonRemoveRow,onRemoveColumn,onRemoveFieldto documentation tableThese callbacks follow the same pattern as existing
onUpdate*callbacks but fire when components are added or removed rather than updated.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.