BaseObject String(value) 替换为 value.toString() 提高性能
#167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`String(value)` 即便是对象本身没有实现 `toString()` 方法的情况下，性能都要低几倍 可参考 https://tc39.es/ecma262/multipage/text-processing.html#sec-string-constructor 会在`toString()`之前做了多个检查 而 DragonBones 中所有class，都实现了 `toString()` 方法，性能更高 毕竟这是一个大量调用的方法
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String(value)即便是对象本身没有实现toString()方法的情况下，性能都要低几倍可参考 https://tc39.es/ecma262/multipage/text-processing.html#sec-string-constructor
会在
toString()之前做了多个检查而 DragonBones 中所有class，都实现了
toString()方法，性能更高毕竟这是一个大量调用的方法