#104 Fixed navigationbar on detail screen.#542
#104 Fixed navigationbar on detail screen.#542valjapan wants to merge 15 commits intoDroidKaigi:masterfrom
Conversation
…avigation_bar_at_sessionn_detail_screen fix conflict
…avigation_bar_at_sessionn_detail_screen Avoid build version warning
| false | ||
| ) | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
| activity?.window?.decorView?.systemUiVisibility = |
There was a problem hiding this comment.
Thanks!
We are using SystemUiManager class. can you check it? 🙏
There was a problem hiding this comment.
@takahirom
sorry. I was busy working and couldn't help.
Unfortunately I couldn't call SystemUiManager.
Could you give me any advice?
There was a problem hiding this comment.
Of course!
How about moving SystemUiManager to corecomponet?
There was a problem hiding this comment.
@takahirom
This is solved using SystemUiManager! Thank you for the advice!
commit a08be2a
jmatsu
left a comment
jmatsu
left a comment
There was a problem hiding this comment.
Thank you so much! The approach looks good. Could you please address only one point which was from takahirom? ref: https://github.com/DroidKaigi/conference-app-2020/pull/542/files#r370191036
|
Sorry for the late resolution of the issue. |
…avigation_bar_at_sessionn_detail_screen Fix issue 104 hardly see the navigation bar at sessionn detail screen
|
Your apk has been deployed to https://deploygate.com/distributions/dc687d5465b94fd172d3794aa7a964d29a26cddd. Anyone can try your changes via the link. Generated by 🚫 Danger |
|
|
||
| navigationBarColors.systemUiVisibility.distinctUntilChanged().observe(this) { | ||
| activity?.window?.decorView?.systemUiVisibility = | ||
| View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR or View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR |
There was a problem hiding this comment.
Field requires API level 23 (current min is 21): android.view.View#SYSTEM_UI_FLAG_LIGHT_STATUS_BAR |
|
|
||
| navigationBarColors.systemUiVisibility.distinctUntilChanged().observe(this) { | ||
| activity?.window?.decorView?.systemUiVisibility = | ||
| View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR or View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR |
There was a problem hiding this comment.
Field requires API level 26 (current min is 21): android.view.View#SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR |
|
No error was reported but at least one warning was found. Generated by 🚫 Danger |
4 participants
Since I did not push my master branch, I will push again.
Here is the previous pull request.(#461)
Issue
Overview (Required)
Notes
systemUiVisibility. Thank you for the advice.Screenshot