Use UI state in profile edit screen#508
Open
Masaki-U wants to merge 10 commits intoDroidKaigi:mainfrom
Open
Conversation
Member
|
Thank you for your pull request. Could you please resolve the conflict? |
…eature/use_ui_state_in_profile_edit_screen
Author
|
@takahirom |
|
Detekt check failed. Please run |
Member
|
I apologize. I created a similar issue, and there are conflicts in this PR. I believe we can still use your code, such as ImageData. Could you please resolve the conflict? |
| "" | ||
| } | ||
|
|
||
| val occupationError @Composable get() = if (occupation.isEmpty()) { |
Contributor
There was a problem hiding this comment.
The same basic code format is repeated here three times... it might be worth to make a generic version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)