Use cardType property instead of theme, since the property is Deprecated#653
Open
fumiya-kume wants to merge 3 commits intoDroidKaigi:mainfrom
Open
Use cardType property instead of theme, since the property is Deprecated#653fumiya-kume wants to merge 3 commits intoDroidKaigi:mainfrom
fumiya-kume wants to merge 3 commits intoDroidKaigi:mainfrom
Conversation
…ted in ProfileCardJson
…ted in ProfileCardJson
Member
|
Thanks! We need the property for compatibility with older versions of the JSON, as you can see from the failing test. How about adding a comment like "This exists for compatibility" instead of removing it? |
Author
|
@takahirom Thanks! I added again with explain comment. |
|
Detekt check failed. Please run |
takahirom
reviewed
Aug 19, 2024
| val image: String, | ||
| @Deprecated("Use cardType instead", replaceWith = ReplaceWith("cardType")) | ||
| @Deprecated( | ||
| "Let's use cardType, but keep it for compatibility.", |
Member
There was a problem hiding this comment.
Thank you for adding this. This deprecation message will be shown when developers use this field, so personally the phrase 'keep it' might be a little difficult for developers to understand what they need to do. I recommend adding a separate comment to clarify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
ProfileCardJson, so replace it.Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)