Conversation
|
Detekt check failed. Please run |
|
Fixed formatting. Ready for review. |
|
Detekt check failed. Please run |
| derivedStateOf { (height - TimetableGridItemSizes.padding * 2) / 4 > titleMinHeightDp * 3 / 2 } | ||
| } | ||
|
|
||
| ProvideRoomTheme(timetableItem.room.getThemeKey()) { |
There was a problem hiding this comment.
Our formatter says this. Could you check it out?
/home/runner/work/conference-app-2024/conference-app-2024/feature/sessions/src/commonMain/kotlin/io/github/droidkaigi/confsched/sessions/component/TimetableGridItem.kt:109:22: Extra braces exist on this branch, remove them. [BracesOnIfStatements]
/home/runner/work/conference-app-2024/conference-app-2024/feature/sessions/src/commonMain/kotlin/io/github/droidkaigi/confsched/sessions/component/TimetableGridItem.kt:109:61: Extra braces exist on this branch, remove them. [BracesOnIfStatements]
There was a problem hiding this comment.
Weird. I ran the format fixer....
I will try to fix this.
|
@takahirom fixed (again) |
| } | ||
|
|
||
| ProvideRoomTheme(timetableItem.room.getThemeKey()) { | ||
| ProvideRoomTheme(if (timetableItem.isLunch) "lunch" else timetableItem.room.getThemeKey()) { |
There was a problem hiding this comment.
How about passing isLunch to getThemeKey()?
|
I would like to have a fake session for lunch which will be used for screenshot tests. It could break unexpectedly otherwise. |
|
Detekt check failed. Please run |
|
Detekt check failed. Please run |
| jaTitle = "${fake.title.jaTitle} $day $index", | ||
| enTitle = "${fake.title.enTitle} $day $index", | ||
|
|
||
| if(start == DroidKaigi2024Day.Workday.start + 13.hours) { |
There was a problem hiding this comment.
There may not be a DroidKaigi 2024 Day 1 session starting at 1 PM.
I think we can place this above the for-loop.
Could you please check?
There was a problem hiding this comment.
ok. I will look now. Sorry about yesterday (I was unwell yesterday and needed to rest)
There was a problem hiding this comment.
@takahirom if you mean day zero... do we need test data for that?
We cut day zero from the timetable.
There was a problem hiding this comment.
I think we don't need this if statement, and we can move the add statement outside of the for-loop.
Additionally, I believe we should use DroidKaigi2024Day.ConferenceDay1.start instead of DroidKaigi2024Day.Workday.start for startsAt and endsAt.
|
Adjusted as requested. 🙇 |
| TimetableItem.Special( | ||
| id = TimetableItemId("7"), | ||
| title = MultiLangText("Lunch break", "Lunch break"), | ||
| startsAt = DroidKaigi2024Day.Workday.start + 13.hours, |
There was a problem hiding this comment.
I think this is still DroidKaigi2024Day.Workday 👀
There was a problem hiding this comment.
oops, sorry I forgot to fix that part.
There was a problem hiding this comment.
@takahirom sorry about that. Fixed as requested.
|
Additional requested actions:
|
2 participants
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)