Conversation
|
Detekt check failed. Please run |
|
I don't think we have a CI set up for running this test, which means it could break at any time. Could you add it? I think running just one task is enough. |
| - run: | | ||
| ./gradlew \ | ||
| :core:data:iosSimulatorArm64Test \ | ||
| :core:model:iosSimulatorArm64Test \ | ||
| --stacktrace |
There was a problem hiding this comment.
I apologize for delay. 🙇
There were another module for which iOS tests were not being run, so I specified them.
I am not similar with Gradle syntax, but is this acceptable?
| - run: | | ||
| ./gradlew \ | ||
| :core:data:iosSimulatorArm64Test \ | ||
| :core:model:iosSimulatorArm64Test \ | ||
| --stacktrace |
There was a problem hiding this comment.
Thanks! The iosSimulatorArm64Test might be skipped on ubuntu-latest. Could we change ubuntu-latest to macos-latest?
Additionally, we might need to modify the screenshot-comparison workflow to use macos-latest so that we have the same environment for the screenshots. I think we could merge the existing tests to speed up the process.
- run: ./gradlew \
testDevDebugUnitTest \
testDebugUnitTest \
:core:data:iosSimulatorArm64Test \
:core:model:iosSimulatorArm64Test \
--stacktraceThere was a problem hiding this comment.
There was a problem hiding this comment.
Sorry, CI failed 🙇
I will try to fix
Issue
Overview (Required)
Acceptance conditions
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)