Skip to content
This repository was archived by the owner on Feb 1, 2019. It is now read-only.

Bintrie#63

Open
jamesray1 wants to merge 25 commits into
Drops-of-Diamond:developfrom
ChosunOne:bintrie
Open

Bintrie#63
jamesray1 wants to merge 25 commits into
Drops-of-Diamond:developfrom
ChosunOne:bintrie

Conversation

@jamesray1
Copy link
Copy Markdown
Member

Opening for comparison.

@jamesray1
Copy link
Copy Markdown
Member Author

@ChosunOne is this ready for review or are you still working on this?

@ChosunOne
Copy link
Copy Markdown

Still working on it. Note the conspicuous lack of passing tests

@jamesray1
Copy link
Copy Markdown
Member Author

No pressure or anything, just don't want to look at it until you give the go-ahead. Take your time with it.

@jamesray1 jamesray1 added the A3: in progress Pull request is in progress. No review needed at this stage. label May 14, 2018
@jamesray1
Copy link
Copy Markdown
Member Author

@ChosunOne are you too busy to work on this; shall I assign it to someone else?

@roveneliah
Copy link
Copy Markdown

@jamesray1 I'm working on the same thing with go-ethereum. Let me know if you're still interested in this.

@jamesray1
Copy link
Copy Markdown
Member Author

jamesray1 commented Jun 14, 2018

Yes, @tcsiwula has started work on this. I'm working on sharding p2p with gossipsub. However, we're happy to collaborate, and there is much work to do.

@roveneliah
Copy link
Copy Markdown

Forgot to mention this, but my go implementation of a binary trie might be of interest. While proofs ended up being about half the size of radix 16 proofs, this is still far from optimal as mentioned here. I'm interested in optimizing this further and would appreciate feedback.

@jamesray1
Copy link
Copy Markdown
Member Author

Hi Eli,

Thanks for your message. At the moment I'm working on gossipsub, but once that's done I will work on other things like the bintrie and implementing shasper once the spec is finalized. Perhaps @paulhauner may have time to work on a bintrie.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A3: in progress Pull request is in progress. No review needed at this stage.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants