fix(verifier): bind the configured address and port - #1152
Open
Leechael wants to merge 2 commits into
Open
Conversation
Rocket 0.6 DefaultListener treats `address` as an Endpoint. A bare IP such as `0.0.0.0` from dstack-verifier.toml parses as tcp:0.0.0.0:8000, and `.launch()` binds that socket. `port` from the toml file or DSTACK_VERIFIER_PORT is extracted into the app Config and validated, but it never reaches the listener, so operators cannot move the HTTP server off 8000. Bind a tokio TcpListener from the already-validated Config address/port and `launch_on` it. That matches how guest-agent and supervisor start Rocket, and keeps listen-address selection in one place instead of hoping Figment keys overlay Rocket's Endpoint default. Verified with `cargo test -p dstack-verifier --bin dstack-verifier` (2 passed).
The verifier Config field is `address`, and unknown fields are rejected. The README listed `host`, so a copied toml failed to load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dstack-verifierreadsaddressandportfrom toml /DSTACK_VERIFIER_*, validates them, then starts Rocket with.launch().Rocket 0.6
DefaultListenertreatsaddressas anEndpoint. A bare IP such as0.0.0.0parses astcp:0.0.0.0:8000. The configuredportnever reaches the listener, so:Fix
Bind a
tokio::net::TcpListenerfrom the already-validatedConfigaddress/port andlaunch_onit, same pattern as guest-agent and supervisor.Verification
cargo test -p dstack-verifier --bin dstack-verifier— 2 passed, includingsocket_addrfrom the config file port.