Skip to content

include the ID token in the refresh token result #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Erwinvandervalk merged 1 commit into from
Mar 13, 2025
Merged

include the ID token in the refresh token result #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions access-token-management/src/AccessTokenManagement.OpenIdConnect/UserToken.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,11 @@ public class UserToken : ClientCredentialsToken
/// The refresh token
/// </summary>
public string? RefreshToken { get; set; }

/// <summary>
/// The identity token that may be populated by the OP when refreshing the access token. This
/// value is not stored, but available should some OP's require to send this value, for example
/// during logout.
/// </summary>
public string? IdentityToken { get; set; }
}
1 change: 1 addition & 0 deletions access-token-management/src/AccessTokenManagement.OpenIdConnect/UserTokenEndpointService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ public async Task<UserToken> RefreshAccessTokenAsync(
}
else
{
token.IdentityToken = response.IdentityToken;
token.AccessToken = response.AccessToken;
token.AccessTokenType = response.TokenType;
token.DPoPJsonWebKey = dPoPJsonWebKey;
Expand Down
4 changes: 4 additions & 0 deletions access-token-management/test/AccessTokenManagement.Tests/UserTokenManagementTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ public async Task Short_token_lifetime_should_trigger_refresh()
// Respond to refresh with a short token lifetime so that we trigger another refresh on 2nd use
var refreshTokenResponse = new
{
id_token = "refreshed1_id_token",
access_token = "refreshed1_access_token",
token_type = "token_type1",
expires_in = 10,
Expand All @@ -225,6 +226,7 @@ public async Task Short_token_lifetime_should_trigger_refresh()
// Respond to second refresh with a long token lifetime so that we don't trigger another refresh on 3rd use
var refreshTokenResponse2 = new
{
id_token = "refreshed2_id_token",
access_token = "refreshed2_access_token",
token_type = "token_type2",
expires_in = 3600,
Expand All @@ -245,6 +247,7 @@ public async Task Short_token_lifetime_should_trigger_refresh()

token.ShouldNotBeNull();
token.IsError.ShouldBeFalse();
token.IdentityToken.ShouldBe("refreshed1_id_token");
token.AccessToken.ShouldBe("refreshed1_access_token");
token.AccessTokenType.ShouldBe("token_type1");
token.RefreshToken.ShouldBe("refreshed1_refresh_token");
Expand All @@ -256,6 +259,7 @@ public async Task Short_token_lifetime_should_trigger_refresh()

token.ShouldNotBeNull();
token.IsError.ShouldBeFalse();
token.IdentityToken.ShouldBe("refreshed2_id_token");
token.AccessToken.ShouldBe("refreshed2_access_token");
token.AccessTokenType.ShouldBe("token_type2");
token.RefreshToken.ShouldBe("refreshed2_refresh_token");
Expand Down