Enable ForceTokenRenewal of OIDC User Access Token#290
Merged
pgermishuys merged 1 commit intomainfrom Oct 29, 2025
Merged
Conversation
e93e17a to
3100efe
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the User Client Access Token Retriever with the User Access Token Handler to allow forcing token refresh via the OIDC Client Access Token Retriever. The changes set initial tokens to be expired to exercise the Token Endpoint for retrieving access tokens.
Key changes:
- Modified test infrastructure to use expired tokens and User Access Token Handler
- Added support for forced token renewal through request parameters
- Updated service registration from client-based to user-based access token management
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TestAccessTokens.cs | Sets token expiration to -1 second to force token refresh |
| FakeAuthenticationService.cs | Refactored to use async methods and improved code formatting |
| OidcUserFixture.cs | Switched from AddClientAccessTokenHttpClient to AddUserAccessTokenHttpClient |
| AccessTokenHandlerTests.cs | Added test for force token renewal functionality |
| OpenIdConnectUserAccessTokenRetriever.cs | Added ForceTokenRenewal parameter support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...n-management/test/AccessTokenManagement.Tests/AccessTokenHandler/Fixtures/OidcUserFixture.cs
Show resolved
Hide resolved
...n-management/test/AccessTokenManagement.Tests/AccessTokenHandler/Fixtures/OidcUserFixture.cs
Outdated
Show resolved
Hide resolved
3100efe to
127530a
Compare
Erwinvandervalk
previously approved these changes
Oct 29, 2025
127530a to
d602b81
Compare
Erwinvandervalk
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
We want to allow the ability to force the refresh of a token via the OIDC User Access Token Retriever.
Note: