Conversation
maartenba
added
area/products
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Duende Documentation MCP Server by adding exception handling to background indexers for improved stability, and significantly expands the README with comprehensive setup instructions and usage examples.
Key changes:
- Added try-catch blocks with logging to all three background indexers (Samples, Docs, Blog) to handle exceptions gracefully
- Updated package versions for Markdig and ModelContextProtocol
- Expanded README with detailed registration instructions for VS Code, Visual Studio, and JetBrains Rider
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs-mcp/src/Documentation.Mcp/Sources/Samples/SamplesIndexer.cs | Added exception handling to ExecuteAsync method and corrected logger type parameter |
| docs-mcp/src/Documentation.Mcp/Sources/Docs/DocsArticleIndexer.cs | Added exception handling to ExecuteAsync method |
| docs-mcp/src/Documentation.Mcp/Sources/Blog/BlogArticleIndexer.cs | Added exception handling to ExecuteAsync method |
| docs-mcp/src/Documentation.Mcp/Program.cs | Contains a typo in the MCP server instructions |
| docs-mcp/README.md | Comprehensive rewrite with setup instructions, example prompts, and improved technical details |
| Directory.Packages.props | Updated Markdig to 0.43.0 and ModelContextProtocol packages to 0.4.0-preview.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
damianh
approved these changes
Nov 11, 2025
…ocess doesn't exit
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
(rebased) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds several stability improvements (handle exceptions), and fine tuning of the server instructions. Also the README was updated with better guidelines on how to use the MCP server.