Harden FileSystem init error handling and align file-exists test constants - #36
Closed
VenkataKrishnaGarapati with Copilot wants to merge 2 commits into
Closed
Harden FileSystem init error handling and align file-exists test constants#36VenkataKrishnaGarapati with Copilot wants to merge 2 commits into
VenkataKrishnaGarapati with Copilot wants to merge 2 commits into
Conversation
VenkataKrishnaGarapati
marked this pull request as ready for review
June 4, 2026 03:46
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Harden FileSystem init error handling and align file-exists test constants
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the review-thread feedback on
FileSysteminitialization and its regression coverage. It removes broad error suppression during cache directory setup and aligns tests with the shared file-exists error constants used by production code.Initializer error handling
try!directory creation with explicitdo/catchhandling.NSError.isFileExistsErroras ignorable; other creation failures are surfaced viaassertionFailure(...).withIntermediateDirectories: true.Targeted regression tests
FileSystemInitializationTestsfor:createDirectoryreturns “file exists”NSError.FileErrors.domainandNSError.FileErrors.fileExistsErrorCode(no duplicated raw516).