This repository was archived by the owner on Apr 8, 2025. It is now read-only.
vat:validate command not found: fixed #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vatlayer API can return errors if for example monthly usage limit has been reached. In this case $clientResponse will not have key: 'valid', so exception.log is flooded by: `Notice: Undefined index: valid` Vatlayer documentation tells us error key will exist if there is an error. The error info is now also visible in the FailedValidationException.
Add extra check in validateVATNumber
Fix for config class
Fix wrong api call
…ance Fix PSR2 compliance + comments
+ added api key - removed unused keys
- removed types + added virtual types
+ configuration interface with all paths to config.xml + configuration implementation
+ the name is used to decouple from validation which makes it dynamic
the constructor tried to resolve something which is only needed at runtime
- removed secondary logic from constructor + implemented configuration whih moves scope logic to configuration + cache multiple calls
+ add configuration interface - removed direct scope calls for configuration
- removed direct implementation of Validation services + Inject cleannumberString object
* delimiters are required
…id, because validation failed implies an error while trying to validate
Keep request_message a Phrase object instead of coercing string
Fix from @evs-xsarus report.ERROR: Deprecated Functionality: preg_replace(): Passing null to parameter
…(as Magento core does)
Makes the module installable on Magento 2.4.7.
The example "./bin/magento vat:validate NL NL133001477B01" did not run because the name "test" was already in use in di.xml. This is a common name, which can cause naming problems in other cases.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example "./bin/magento vat:validate NL NL133001477B01" did not run because the name "test" was already in use in di.xml. This is a common name, which can cause naming problems in other cases.