feat(new): code/ audit zone + symlink custom workspaces (board discovery)#13
Merged
Conversation
…E_ROOT
Adds a code/{sources,sourcemaps,js,beautified} white-box audit zone to the workspace. When an engagement is created in a custom path, dotsec symlinks it back to WORKSPACE_ROOT/<target> so the board, browser, status and rm all discover it (Docker follows the symlink for mounts). rm resolves the link to delete the real workspace + the link. Fixes the dashboard showing 'Create one' for custom-path engagements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code/{sources,sourcemaps,js,beautified}white-box / source-map audit zone to every new workspace.dotsec newcreates an engagement in a custom path, it symlinks it back toWORKSPACE_ROOT/<target>so the board (was stuck on "Create one"),browser,status,rmall discover it. Docker follows the symlink for mounts;rmresolves the link to delete the real workspace + the link.Test plan
make test(70 bats) +make lintdotsec new probe3 <custom>→code/present, symlink in WORKSPACE_ROOT,__homer_gen_configlists the engagement