merge next to main #406
Draft
merge next to main #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/ribbon fontobj support
Fix/ribbon alignment height
…ing time from the server
Style menu with CSS
Fix/ribbon width
See comment - the way this appears to work in windoows is that the last item clicked on (without shift) is used as the base index.
This reverts commit af62575.
This commit fixes FontObj for Label, Button and Edit Note that this also provides a *generalised* approach to inheritance. The existing code tried to do this via eg assuming that a text-decoration CSS style would be inherited. It is not. See https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration
I'm not sure this is the ultimate solution, but it does now at least use the same styling function as everything else (getFontStyles) and therefore actually respects different fonts and any other styling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.