Test math - #52
Merged
Merged
Test math#52
Conversation
- added -= - added /= - all functions are tested - operator[] should be removed
Nikos-d
marked this pull request as ready for review
May 13, 2026 19:24
ThomasDuquette
requested changes
May 14, 2026
ThomasDuquette
left a comment
ThomasDuquette
left a comment
Contributor
There was a problem hiding this comment.
Add test for non-trivial cross product. Add test for other operators than subtract?
ThomasDuquette
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added -= and /= operators to Vec3.
Added Note in comment on using operator[] (unsafe)
added test for Vec3