Broadphase implementation - #77
Merged
Merged
Conversation
| return; | ||
| } | ||
|
|
||
| if (child_type1 == CollisionObjectType::aabb && child_type2 == CollisionObjectType::capsule) { |
Contributor
There was a problem hiding this comment.
Is this better than nested if? @gallantandre. Also, I think we should start with the most common if block, so AABB=AABB?
Contributor
Author
There was a problem hiding this comment.
Based on Tracy profiling, most common if block is aabb vs capsule
Member
There was a problem hiding this comment.
@ThomasDuquette Yes, I think generally it's better than a nested if, as long as there is no overlap.
Member
There was a problem hiding this comment.
That being said, there is a lot of nesting conditionals here. There’s probably some analysis that we could do to increase the performance, but the algorithm itself is pretty branchy, so I don’t know if there’s actually anything we can do to make it better.
gallantandre
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.