i#3544 RV64: Implement relink_special_ibl_xfer() #7437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to AArch64, we cannot jump to an address storing in memory directly on RISC-V, thus an instruction sequence of loading to scratch (ld) and branching to register (jalr) must be used in special IBL. It's only required to adjust the offset used in loading insturction during relinking. This commit is tested by manually inspecting the relinked IBL in debugger and applications that make use of shared libraries, for example, ld.bfd with LTO plugin, where the address range is flushed on library unloading. Issue: DynamoRIO#3544
ksco
approved these changes
Apr 7, 2025
derekbruening
approved these changes
Apr 7, 2025
|
I'm too busy this month and plan to continue working on the PR in May. Thanks for your patience :) |
derekbruening
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to AArch64, we cannot jump to an address storing in memory directly on RISC-V, thus an instruction sequence of loading to scratch (ld) and branching to register (jalr) must be used in special IBL. It's only required to adjust the offset used in loading insturction during relinking.
As drwrap-related tests aren't enabled on RV64, this commit is tested by manually inspecting the relinked IBL in debugger and applications that make use of shared libraries, for example, ld.bfd with LTO plugin, where the address range is flushed on library unloading. Unit tests could be introduced later.
Issue: #3544