i#7943: Set vector length in view tool - #7944
Merged
Merged
Conversation
Looks for the vector length marker and sets the decoder vector length
based on its value. This is required to decode the proper displacement
for some SVE instruction's memory operands.
Adds a unit test.
Further tested on the original trace where this was noticed:
Before:
```
$ ctest -V -R off.allasm-scattergather-b
$ clients/bin64/drmemtrace_launcher -indir suite/tests/tool.drcacheoff.allasm-scattergather-basic-counts.allasm_scattergather.*.dir -tool view 2>&1 | less
1408 240: W0.T909560 ifetch 4 byte(s) @ 0x0000000000400508 a401a03c ld1b (%x1)[1byte] %p0/z -> %z28.b
```
After:
```
$ ctest -V -R off.allasm-scattergather-b
$ clients/bin64/drmemtrace_launcher -indir suite/tests/tool.drcacheoff.allasm-scattergather-basic-counts.allasm_scattergather.*.dir -tool view 2>&1 | less
1408 240: W0.T909560 ifetch 4 byte(s) @ 0x0000000000400508 a401a03c ld1b +0x10(%x1)[1byte] %p0/z -> %z28.b
```
Fixes #7943
abhinav92003
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks for the vector length marker and sets the decoder vector length based on its value. This is required to decode the proper displacement for some SVE instruction's memory operands.
Adds a unit test.
Further tested on the original trace where this was noticed:
Before:
After:
Fixes #7943