refactor(settings): settings client uses permission handling from core lib #1873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0weinberger
force-pushed
the
refactor/settings-client-uses-core-lib-permission-handling
branch
2 times, most recently
from
dfd4473 to
8ef2bb9
Compare
d0weinberger
force-pushed
the
refactor/settings-client-uses-core-lib-permission-handling
branch
3 times, most recently
from
8198fad to
070b4c2
Compare
d0weinberger
force-pushed
the
refactor/settings-client-uses-core-lib-permission-handling
branch
from
070b4c2 to
3b2231d
Compare
arthurpitman
added
the
run-e2e-test
Kirdock
approved these changes
May 19, 2025
…e lib When creating a new settings client, the nested rest client is also used to create the core lib permission client.
d0weinberger
force-pushed
the
refactor/settings-client-uses-core-lib-permission-handling
branch
from
3b2231d to
ab405e7
Compare
|
d0weinberger
deleted the
refactor/settings-client-uses-core-lib-permission-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
The code for interacting with the settings object permission API has moved to the core library, such that it can be shared also with the Terraform provider.
What has changed?
The main change is in settings_client.go, where, instead of calling the permission API directly, the permission client of the core library is used.
How does it do it?
When creating a new settings client, the nested rest client is also used to create the core lib permission client.
How is it tested?
No new functionality was added. Code was moved and the existing tests still pass.
Actually, the existing tests have been improved to be more specific.
How does it affect users?
NO user impact.