fix(account): validate environment name when loading a group #2095
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a check to ensure each environment in a group has a name. Updates tests to cover the case where the environment name is missing and adds a corresponding test YAML file.
Kirdock
force-pushed
the
fix/account/validate-group-environment-name
branch
from
b0c587e to
ba15929
Compare
|
tomazpu
approved these changes
Jan 14, 2026
d0weinberger
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
If a group has some environments defined, the environment name is required. This is not checked when loading the group. Therefore, we should add a check.
What has changed?
An error is returned when loading a group if the environment name is empty
How does it do it?
By adding a non-empty check for the environment name of groups.
How is it tested?
New test added that checks if a missing environment name returns an error.
How does it affect users?
They will now get an error if the environment name is not defined
Issue: CA-17625