Draft
Conversation
odubajDT
force-pushed
the
journald-introduce
branch
from
c0e6f27 to
aef165e
Compare
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
force-pushed
the
journald-introduce
branch
from
a8d354a to
de5ddc9
Compare
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
RealAnna
force-pushed
the
journald-introduce
branch
from
ab86df6 to
589c06b
Compare
odubajDT
commented
Mar 12, 2026
internal/testbed/integration/hostmetrics/testdata/e2e/expected-5m.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
odubajDT
commented
Mar 13, 2026
| startTimeUnixNano: "1000000" | ||
| timeUnixNano: "2000000" | ||
| unit: By | ||
|
|
| @@ -0,0 +1,37 @@ | |||
| extensions: | |||
Contributor
Author
There was a problem hiding this comment.
this file is not needed anymore, can be removed
| } | ||
| } | ||
|
|
||
| func Debug(err error, t *testing.T, expectedMerged pmetric.Metrics, actualMerged pmetric.Metrics) { |
Contributor
Author
There was a problem hiding this comment.
this function is good, but covers only resources and it's atributes, can you maybe extend it to cover also scopes and metrics? Potentially we can make it more general and just paste the full actual yaml here - we can then use AI to compare the differences, does not even need to be nicely formatted :) It does not need to be part of this PR, just a potential improvement for future
Contributor
There was a problem hiding this comment.
I was thinking if it makes sense to have different level of details but yeah since AI maybe a single print all would be good enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.