Add model watchlist candidates#11
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughPreset-based model recommendations now append a "watchlist" candidate set for models from unknown families. A new ChangesWatchlist Recommendation Feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cbe987cc5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case "classifier", "simple", "default", "complex", "multimodal": | ||
| return func(m uiModel) (float64, float64) { return roleQuality(m, role), effectiveBlendedPriceOf(m) } |
There was a problem hiding this comment.
Use prompt price for classifier watchlist ranking
For the classifier preset, the existing axes rank by prompt price because the classifier emits only a tiny completion, but watchlist candidates now use blended input/output cost. When an outside-allowlist classifier has cheap input tokens but expensive output tokens, it can be ranked and labeled as worse value than a model with higher prompt cost, even though the route's actual cost is prompt-dominated and the regular classifier preset would prefer it.
Useful? React with 👍 / 👎.
Summary
Tests
Summary by CodeRabbit
New Features
Bug Fixes