Skip to content

Surface htmx errors in admin UI #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzarlax merged 1 commit into from
Jun 16, 2026
Merged

Surface htmx errors in admin UI #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions internal/adminapi/templates/partials_layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,25 @@
<link rel="stylesheet" href="/static/dzarlax.css">
<script src="/static/dzarlax.js" defer></script>
<script src="/static/htmx.min.js" defer></script>
<script>
document.addEventListener("htmx:beforeSwap", function (event) {
var detail = event.detail || {};
var xhr = detail.xhr;
if (!xhr || xhr.status < 400) return;

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear stale inline errors after successful retries

Because this handler returns before finding/removing any existing .admin-inline-error for all <400 responses, a transient htmx failure can leave a stale alert after the user retries successfully. For example, the Refresh catalog button in internal/adminapi/templates/index.html swaps only #models-content, while this handler prepends the error to the surrounding .card__body; a successful retry replaces #models-content but never removes that sibling alert, so the UI continues to show the old failure. Clear the host's prior error before this return or on successful swap.

Useful? React with 👍 / 👎.

detail.shouldSwap = false;
detail.isError = false;
var source = detail.requestConfig && detail.requestConfig.elt ? detail.requestConfig.elt : event.target;
var host = source && source.closest ? source.closest("[data-model-card], .card__body, section") : null;
if (!host) host = document.body;
var old = host.querySelector(":scope > .admin-inline-error");
if (old) old.remove();
var box = document.createElement("div");
box.className = "admin-inline-error";
box.setAttribute("role", "alert");
box.textContent = (xhr.responseText || ("Request failed with HTTP " + xhr.status)).trim();
host.prepend(box);
});
</script>
<style>
/* Admin UI overrides on top of the dzarlax design system. Anything that
duplicates DS is deliberately absent — we rely on DS components for:
Expand Down Expand Up @@ -41,6 +60,7 @@
.model-op-status.running { color: var(--accent, #2563eb); }
.model-actions__check.htmx-request button, .model-actions__eval.htmx-request button { pointer-events: none; opacity: 0.7; }
.model-actions__check .htmx-indicator, .model-actions__eval .htmx-indicator { margin-left: 0.35rem; }
.admin-inline-error { margin-top: 0.5rem; padding: 0.45rem 0.6rem; border-radius: 6px; background: rgba(154,91,0,0.10); color: var(--warning, #9a5b00); font-size: 0.82rem; }
.model-actions__override { display: flex; gap: 0.35rem; align-items: center; flex-wrap: wrap; }
.model-actions__override .form-input { width: 12rem; min-width: 9rem; font-size: 0.8rem; }
.catalog-list-section { margin-bottom: 1rem; }
Expand Down
Loading