Improve model eval timing and ARM64 builds#22
Conversation
|
Warning Review limit reached
More reviews will be available in 27 minutes and 26 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThree unrelated maintenance changes: ChangesModel Eval Timeout Refactor
Repo Infrastructure and Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28b1546032
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ctx, cancel := context.WithTimeout(context.Background(), modelEvalTimeout) | ||
| defer cancel() | ||
| status := s.runModelEval(ctx, provider, modelID, caps) | ||
| status := s.runModelEval(context.Background(), provider, modelID, caps) |
There was a problem hiding this comment.
Restore a bounded request context for model evals
When the requester disconnects or a proxy gives up on this synchronous htmx request, the eval now continues under an unbounded context.Background(). With the current 13-case workload and the new 90s per-case timeout, this can keep modelEvalMu held and continue issuing cloud/paid model calls for roughly 20 minutes after the request is gone; the previous suite deadline stopped new cases after about 45s. Please derive the eval context from r.Context() with an overall deadline, or run evals as an explicit background job with cancellation/status handling.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Line 354: In the AGENTS.md file, locate the section documenting the Codex
Bridge MCP sync behavior near the MCP_BRIDGE_EXPORT_PATH environment variable
description. The text currently refers to "Codex Desktop format" but should be
updated to use "Claude Desktop format" to align with the correct terminology
used in coding guidelines. Simply replace "Codex Desktop format" with "Claude
Desktop format" in the documentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d20ec653-a75f-4fb3-b63d-7290a6331aa5
📒 Files selected for processing (3)
.github/workflows/docker-arm64.ymlAGENTS.mdinternal/adminapi/model_evals.go
Summary
Tests
Summary by CodeRabbit
Documentation
Improvements
Chores