Skip to content

Show full model descriptions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzarlax merged 1 commit into from
Jun 15, 2026
Merged

Show full model descriptions #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/adminapi/adminapi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@ func TestModelsBrowserRendersCardAndTableModes(t *testing.T) {
if !strings.Contains(html, "Balanced multilingual model") {
t.Fatalf("compact view missing model description: %s", html)
}
if !strings.Contains(html, "<details class=\"catalog-row__description\">") || !strings.Contains(html, "catalog-row__description-full") {
t.Fatalf("compact view should render expandable full description: %s", html)
if strings.Contains(html, "<details class=\"catalog-row__description\">") || strings.Contains(html, "catalog-row__description-full") {
t.Fatalf("compact view should render full description without expandable clamp: %s", html)
}
if strings.Contains(html, "catalog-audit-table") {
t.Fatalf("compact view should not render audit table")
Expand Down
6 changes: 0 additions & 6 deletions internal/adminapi/templates/partials_layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@
.catalog-row__name { margin-top: 0.12rem; color: var(--text-secondary); font-size: 0.78rem; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
.catalog-row__chips { display: flex; gap: 0.3rem; flex-wrap: wrap; }
.catalog-row__description { margin-top: 0.4rem; color: var(--text-secondary); font-size: 0.8rem; line-height: 1.35; }
.catalog-row__description summary { cursor: pointer; display: -webkit-box; -webkit-line-clamp: 2; -webkit-box-orient: vertical; overflow: hidden; list-style: none; }
.catalog-row__description summary::-webkit-details-marker { display: none; }
.catalog-row__description summary::after { content: " More"; color: var(--accent); font-weight: 600; white-space: nowrap; }
.catalog-row__description[open] summary { display: none; }
.catalog-row__description-full { color: var(--text-secondary); }
.catalog-row__why { font-size: 0.86rem; color: var(--text); }
.catalog-row__reasons, .catalog-row__warnings { display: flex; gap: 0.35rem; flex-wrap: wrap; margin-top: 0.4rem; font-size: 0.78rem; }
.catalog-row__reasons { color: var(--text-secondary); }
Expand Down Expand Up @@ -117,7 +112,6 @@
.catalog-view-toggle .btn, .catalog-tabs .btn { flex: 1 1 auto; }
.catalog-sort, .catalog-sort-dir { flex: 1 1 8rem; width: auto; }
.catalog-row { grid-template-columns: 1fr; gap: 0.65rem; }
.catalog-row__description summary { -webkit-line-clamp: 3; }
.catalog-grid { grid-template-columns: 1fr; }
.catalog-card { padding: 0.75rem; }
.catalog-card__header { flex-direction: column; gap: 0.5rem; }
Expand Down
5 changes: 1 addition & 4 deletions internal/adminapi/templates/partials_models_row.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,7 @@
</div>
</div>
{{if .Description}}
<details class="catalog-row__description">
<summary>{{.Description}}</summary>
<div class="catalog-row__description-full">{{.Description}}</div>
</details>
<div class="catalog-row__description">{{.Description}}</div>
{{end}}
</div>

Expand Down
Loading